Conversation
When commands like `git commit --fixup` create commits, they use the style `fixup!`, rather than the `!fixup` style checked for by CI. Unfortunately this stems from a mistake when the checker was originally implemented, but both forms are kept in case anyone uses the old form manually.
samdbmg
force-pushed
the
sammg/ci/commit-check
branch
from
f557c5f to
2286557
Compare
j616
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When commands like
git commit --fixupcreate commits, they use the stylefixup!, rather than the!fixupstyle checked for by CI. Unfortunately this stems from a mistake when the checker was originally implemented, but both forms are kept in case anyone uses the old form manually.This was tested to work in https://github.com/bbc/tams/actions/runs/21916998990/job/63286791435?pr=174 (the accompanying change has been rebased out)
Jira Issue (if relevant)
Jira URL: N/A (came up while doing #172 )
Related PRs
N/A
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.